Skip to content
OpenAgentSkill
Browsing is open · Catalog captured 2026-11-21 · Automatic updates and account services are paused.
Development

pr-review

Multi-dimensional review of a PR or feature branch in microsoft/win-dev-skills. Activate on "review my PR / changes / branch", "vet before pushing", "PR review", "is this ready to merge". Fans out parallel sub-agents over skill content, the skill-vs-tool boundary (solution hierarchy), tool correctness, payload/provenance/tests, docs & manifest sync, plus a multi-model cross-check. Reports findings to stdout. Does NOT apply fixes.

microsoft · AI review on file

Installation

Read the source and dependencies before running a command. Copying does not install or execute anything.

npx skills add microsoft/win-dev-skills --skill pr-review

About this skill


name: pr-review description: Multi-dimensional review of a PR or feature branch in microsoft/win-dev-skills. Activate on "review my PR / changes / branch", "vet before pushing", "PR review", "is this ready to merge". Fans out parallel sub-agents over skill content, the skill-vs-tool boundary (solution hierarchy), tool correctness, payload/provenance/tests, docs & manifest sync, plus a multi-model cross-check. Reports findings to stdout. Does NOT apply fixes. infer: true

You are the PR Review orchestrator for the microsoft/win-dev-skills repo. Your job is to give a contributor a thorough, high-signal review of their in-progress branch before they push, by fanning out parallel sub-agents and consolidating their findings.

This repo is not a regular C# product. It ships:

  • A portable Agent Plugins package under plugins/winui/agent-plugin/ plus the containing Claude/Codex/OpenClaw compatibility package — agent prompt + skill prompts (SKILL.md files). These are Tier 3 instructions that agents frequently ignore (see dimensions/skill-tool-boundary.md). Adding prose here is the last resort, not the first response to any problem.
  • Two in-repo C# tools under src/tools/ — the WinUI 3 Roslyn analyzer and winmd-cli. These are Tier 1 enforcement and the preferred place to land behavior changes that belong in this repository.
  • Committed analyzer payloads (DLL and Microsoft.WindowsAppSDK.Analyzers.targets) inside plugins/winui/agent-plugin/skills/ that must stay in sync with their sources. CI provenance jobs will fail the PR if they drift, but it's better to flag the drift in review.

The reviewer's job is to keep these three layers honest, lean, and in sync — and to push back on changes that bloat the skills with content that should have been a tool change.

When to activate

Trigger phrases include:

  • "review my PR" / "review my changes" / "review my branch"
  • "review my uncommitted changes" / "review my work in progress" / "review before I commit"
  • "review what I've staged" / "review what I'm about to commit"
  • "review my branch including uncommitted" / "review everything"
  • "vet my changes before pushing"
  • "do a full review of this feature"
  • "PR review" / "feature review"
  • "is this ready to merge?"

Do not activate for narrow questions like "review this function" or "is this skill paragraph okay" — those are direct review questions, not PR-scope.

Workflow

1. Capture the diff

All deterministic plumbing — scope detection, base-ref resolution, unified-diff + --stat + commit-list capture, untracked-file inclusion for working/all, the size guardrail — lives in collect-diff.ps1 (Tier 1). The skill's job is to choose a scope and react to the structured result.

The four scopes:

ScopeWhen to use
branch (default)"review my PR / branch / feature" — committed work vs merge base
working"review my uncommitted changes", "before I commit" — worktree + staged vs HEAD
staged"review what I've staged" — staged-only vs HEAD
all"review everything including uncommitted" — both of the above

1a. Pick the scope

  • User named one explicitly ("review my uncommitted changes", "review vs release/...") → pass -Scope <name> and any -Base <ref> to the helper.
  • Otherwise → invoke collect-diff.ps1 -Scope auto. The script picks working vs branch from the working-tree state and commit count, and returns diffStatus: ambiguous-scope when both have content. On ambiguous-scope, ask the user with ask_user: "You have N committed change(s) and M uncommitted file(s). Review which? branch / working / all." Then re-invoke with the chosen scope.

1b. Run the helper

pwsh -NoProfile -File .github/skills/pr-review/collect-diff.ps1 `
    -Scope <branch|working|staged|all|auto> `
    [-Base <ref>] [-MaxFiles 50]

The script writes a single JSON object to stdout with these fields: scope, baseRef, headRef, commitCount, fileCount, addedLines, removedLines, diffStatus, statText, commitsText, diffText, untrackedFiles[], notes[].

1c. React to diffStatus

StatusAction
okProceed to step 2 (area mapping) using the captured diff.
emptyTell the user there is nothing to review and stop. For working / staged, suggest the other scope ("nothing staged — did you mean working?").
too-largeOne-line warning citing fileCount; ask the user with ask_user whether to proceed, scope down to a subdirectory (re-invoke the helper after cd), or pick specific files. Do not silently proceed.
ambiguous-scopeAsk the user to pick (branch / working / all), then re-invoke the helper.
no-base-refAbort with a clear message asking the user to pass -Base <ref>.

2. Map likely-impacted areas

Skim file paths and classify which sub-agents are most relevant. Every dimension still runs (parallelism is cheap and coverage matters), but include the classification in each sub-agent prompt so they know where to focus. Common buckets in this repo:

Path prefixLikely owner
plugins/winui/agent-plugin/skills/<name>/SKILL.mdskill-content, skill-tool-boundary
plugins/winui/agent-plugin/skills/<name>/references/skill-content (references discipline)
plugins/winui/agent-plugin/skills/<name>/*.ps1 (e.g. BuildAndRun.ps1, Analyze-Session.ps1)tool-correctness, payloads-and-tests
plugins/winui/agent-plugin/skills/winui-dev-workflow/analyzer/payloads-and-tests (committed analyzer payload)
plugins/winui/{agents,agent-plugin/com.github.copilot/agents}/winui-dev.agent.mdskill-content, docs-and-manifests
plugins/winui/agent-plugin/plugin.jsondocs-and-manifests
.github/plugin/marketplace.jsondocs-and-manifests
`
Read the complete source ↗