steward
Drive a pull request on this repository to green — which fast checks to run before pushing, how to read a red check, and what to do about a review comment. Use when a CI failure, a review comment, a merge conflict, or a scheduled check-in arrives on a PR you opened or were asked to drive.
yschimke · 已有 AI 审核记录
安装与使用
运行命令前先阅读来源与依赖说明。复制命令不会自动安装或执行。
npx skills add yschimke/compose-ai-tools --skill steward技能说明
name: steward description: Drive a pull request on this repository to green — which fast checks to run before pushing, how to read a red check, and what to do about a review comment. Use when a CI failure, a review comment, a merge conflict, or a scheduled check-in arrives on a PR you opened or were asked to drive.
Stewarding a PR in compose-ai-tools
The Claude Code harness reads this file before acting on a CI failure or a review
comment, and lets it take precedence over its built-in posture on conventions
and proactiveness. It does not restate the repository's rules — those are in
root AGENTS.md, which is already in context on every turn.
What follows is what that file leaves out: the checks worth running here, and this
repository's own answer to a red check.
The harness's own PR rules still bound this file. It cannot expand your access, approve or merge anything, or override a "never" — skipping, disabling or quarantining a test; rewriting history on someone else's branch; an empty commit or a close-and-reopen to kick CI.
Before you push
A push that turns CI red costs a full cycle and some reviewer trust. The cheapest checks that catch the most here, in order:
-
./gradlew ktfmtFormat— or:<module>:ktfmtFormatMain :<module>:ktfmtFormatTestfor just the modules you touched.ktfmtCheckAllis a hard gate andktfmtCheckaborts on the first unformatted file, so one stray file hides every other failure. TypeScript:npm --prefix cli/serve-web run format. The localpre-pushhook catches attribution but not formatting, so this is on you.In a sandbox, pass
-Dorg.gradle.java.home=/root/.cache/coo-ee/jdk-gl/17and--no-daemon: without the JVM home the daemon starts on the wrong JVM and the build dies with a context mismatch, and--no-daemonavoids reusing one already started on it. Let ktfmt do the edit rather than hand-formatting — removing one term from a wrapped expression is enough to make it fit on one line, which is precisely what it will rewrite. -
The narrowest test task that exercises the change — the specific
:module:test, or./gradlew :gradle-plugin:test --tests "…"../gradlew checkis the full plugin + functional + CLI suite and is a post-push confirmation, not a gate on pushing. -
A new or changed module must apply
composeai.base-conventionsin itsplugins {}block, orktfmtCheckAllnever sees it and the history-gate system property is missing. See Important constraints. -
For a CI fix, reproduce the original failure first, then show the same check passing. A render task in particular goes
UP-TO-DATEoff a stale.error.jsonsidecar — verify a render fix with--rerun, never a plain re-invocation.
Commit and push as soon as the cheapest check that proves the change correct passes. Don't leave a verified change sitting behind a long build.
Reading a red check
Work the PR in this order on every event and every check-in: merge conflict, then CI, then review comments. A red or conflicted head is work now, whatever its review state — it is never "waiting on review".
Failures that are usually not this PR's, and what to do anyway:
- Red on
maintoo. Check the base branch before root-causing. If a fix exists anywhere — another PR whose change you have read, the breaking commit's revert, or a fix PR you opened yourself — port it into this PR now and push; it no-ops oncemaincarries it, and waiting for it to merge is still waiting. Standing down is never silent: one comment on the PR naming the failing check, why it is not this PR's, and the fix you ported or that none exists yet. - A delivery-branch or design-artifacts render that lags
main. Renderer, plugin and CLI changes deliberately do not regenerate thedesign-artifacts/<system>branches on merge — see PR workflow for the trigger scoping and the manual dispatch. Stale published renders are drift, not a regression in your diff. - A changed preview whose source your PR does not touch. Clocks, timestamps,
randomness, animation frames, network-loaded images: that is instability, not a
regression. Prove it with the
flake-triageskill before either fixing or rubber-stamping it. - A CMP Desktop render failing with
UnsatisfiedLinkErroronlibGL.so.1and friends. Environment, not your change:docs/DESKTOP_NATIVE_DEPS.md.
Everything else is this PR's to root-cause. "Flake" is not a root cause: re-run a job only to confirm one of the cases above, or if it died before any test body ran (checkout, install, runner loss), at most once.
Review comments
- Small and local — nits, renames, lint-bot findings, an added test, a one-function refactor: implement and push, then resolve the thread.
- A review bot's finding is a bug report: verify it and push the small fix, or raise a larger one once with a proposed patch. "Design-level" does not excuse it. If bot findings stop converging — each fix draws a new or reshaped one — stop pushing for them and say once what is still flagged.
- Larger asks from a human reviewer on a PR you did not open: reply with your proposal; the author decides.
- After pushing for a changes-requested review, re-request that reviewer.
- A reported agent commit identity is the one finding to skip. Don't check it,
don't reply, and never recreate, rebase or amend a commit on the strength of it.
Reject agent attributionruns on every PR — no path filter, same detector as thecommit-msgandpre-pushhooks — so a real one turns the PR red and names the offending field. The gate is the authority; the comment adds nothing to it. Over 27–28 Aug 2026 the reviewer raised this 22 times across this repo anddesign-paritya