设计与 UI
finalize-slice
Finalize an implemented rolling-wave slice for user review. Use when the user wants Codex to review the current branch state against a ready-for-review or in-review slice contract, confirm and fix required findings, repeat review and verification until no required findings remain, ask before accepting findings that materially change project shape or contradict project assumptions, record review state, and leave the clean slice in review for complete-slice.
rijkvanzanten · 已有 AI 审核记录
安装与使用
运行命令前先阅读来源与依赖说明。复制命令不会自动安装或执行。
npx skills add rijkvanzanten/rolling-wave-engineering --skill finalize-slice技能说明
name: finalize-slice description: Finalize an implemented rolling-wave slice for user review. Use when the user wants Codex to review the current branch state against a ready-for-review or in-review slice contract, confirm and fix required findings, repeat review and verification until no required findings remain, ask before accepting findings that materially change project shape or contradict project assumptions, record review state, and leave the clean slice in review for complete-slice.
Finalize Slice
Core Invariants
- Work under
docs/rolling-wave/{project}/. - Store project-level state in
project.md; store slices inslices/NNN-slug.md. - Use slice statuses:
pending,ready,in progress,ready for review,in review,done. - Multiple slices may be
ready,in progress,ready for review, orin reviewconcurrently. Each workflow invocation operates on one explicitly resolved slice. - Accept user preferences by default, but push back when strong evidence conflicts with the workflow, prior decisions, terminology, or constraints.
- Pushback format: "I disagree because... The likely consequence is... Continue anyway?"
- Treat invocation as permission to review, edit product code, run relevant verification, use zero to three focused subagents when useful, and repeat until clean.
- Confirm reviewer findings against code, contract, and repository evidence before fixing them. Do not implement raw reviewer suggestions blindly.
- Fix confirmed findings automatically when they are required by the existing slice contract and do not materially change project shape.
- Ask the user before resolving or accepting a finding that materially changes the finish line, success criteria, roadmap order, project scope, public behavior, compatibility policy, irreversible migration behavior, or a recorded project assumption or decision.
- Preserve the immutable
Original Slice Contract. Record approved deviations in review notes, completion learnings, and project decisions instead of rewriting history. - Review against the slice's expected intermediate state. Do not require an ordinary slice to be production-ready, compiling, runnable, or fully tested when accepted breakage is recorded and tracked.
- Do not add temporary shims, fake fallbacks, placeholder adapters, broad validation, or speculative safeguards merely to make an accepted intermediate state green.
- Keep fixes inside the slice's prepared review decision. Independent usefulness or revertibility alone does not make work out of scope. Record changes needing a separate approval decision, risk class, or verification strategy as roadmap pressure instead of silently expanding the slice.
- Never mark the slice
done. Leave itin review;complete-sliceowns user-approved completion. - Keep going until no confirmed required finding remains, a material project-shape decision requires user input, or a genuine external blocker prevents progress.
- When running inside a Codex goal, mark the goal complete only after the slice is clean and remains
in review. A project-shape question pauses work for user input; it does not complete the goal or become a blocker on its first occurrence.
Workflow
-
Resolve the project and slice.
- Prefer the single slice with status
ready for review; otherwise use the single slice with statusin review. - If multiple candidates exist, ask which one to finalize.
- If only
in progressimplementation exists, stop and route back toimplement-slice; active implementation is not ready for finalization. - If no implemented candidate exists, stop and route to
implement-slice. - Read the slice file first, especially
Original Slice Contract, expected intermediate state, implementation notes, test backlog, prior review notes, and child-project completion condition. - Read only relevant
project.mdsections for finish line, scope, assumptions, decisions, risks, roadmap, and prior learnings. - Treat absent optional slice sections as defaults from
../rolling-wave-common/references/artifacts.md. - Use
../rolling-wave-common/references/lifecycle.mdfor status rules and../rolling-wave-common/references/pushback.mdfor evidence-based pushback.
- Prefer the single slice with status
-
Resolve the review surface.
- Use the target branch named by the user.
- Otherwise use the Git Town parent branch, then branch upstream if Git Town cannot resolve a parent.
- Ask for the target branch only when neither source resolves one.
- When invoked by
deliver-slice, use its immutable handoff for project, slice, base,HEAD, and prior verification only. - Build the mutable review surface once in one batched snapshot: live
HEAD, changed paths, diff stat, staged changes, unstaged changes, untracked paths, and worktree status. - Review the current branch state as a whole against the target branch. Include committed branch changes plus local staged, unstaged, and untracked files.
- Do not assume one branch equals one slice. Previous slices or unrelated branch work matter only when they break the current contract, obscure review, introduce project risk, or contradict expected intermediate state.
- Reuse prior verification results and a recent
code-reviewor finalization pass only when currentHEAD, changed paths, and worktree state still match their recorded review surface. Re-review changed or unresolved areas instead of repeating identical broad passes.
-
Mark or keep the slice
in review.- Set slice status and matching
project.mdroadmap row toin reviewbefore review work. - Append dated passes; never overwrite prior review history.
- Set slice status and matching
-
Run one focused review pass.
- Use
references/finalization-checklist.md. - Start with a local contract and complexity pass before waiting on reviewers.
- Compare current branch state to original contract, expected intermediate state, accepted breakage, implementation notes, and project decisions.
- The fresh finalizer's l
- Use