hora-spec-review
Stage 7 of /hora-spec. Read the whole spec against itself — required sections, observable criteria, nothing reaching forward, every use case satisfiable, no contradiction — and send each shortfall back to the stage that owns it. Invoked by /hora-spec, or directly.
openreachtech · 已有静态检查记录
安装与使用
运行命令前先阅读来源与依赖说明。复制命令不会自动安装或执行。
npx skills add openreachtech/hora-core --skill hora-spec-review技能说明
name: hora-spec-review description: Stage 7 of /hora-spec. Read the whole spec against itself — required sections, observable criteria, nothing reaching forward, every use case satisfiable, no contradiction — and send each shortfall back to the stage that owns it. Invoked by /hora-spec, or directly.
hora-spec-review
Stage 7 of /hora-spec. Every earlier stage wrote a section that agreed with its own conversation. This is the only stage that asks whether they agree with each other.
Read ../hora/references/structure.md and ../hora-spec/references/principles.md first. ../hora-spec/references/stages.md is the authority on this stage's exit condition, ../hora/references/spec-format.md on every rule the mechanical pass checks, and ../hora/references/asking.md on how anything is put to a person.
This stage is never not applicable. A document that six stages wrote and nothing reviewed is a document nobody has read whole.
Besides the document it reads _assets.md and _divergence.md — and, only where the version has already been planned, .hora/tasks/<version>/_plan.md's ## Not accepted, to compare against a count this stage takes for itself. Anything stage 0 recorded under "read but not settled here" that no stage ever settled is a shortfall found here. A _divergence.md row whose Routed to is still blank is the same kind of shortfall, and this is the last gate that can catch it.
What this stage decides
Nothing. It finds, and the stage that owns the section fixes.
| a required section is missing | the stage that owns it re-runs |
a _divergence.md row nobody routed | the stage that owns its subject fills in the Routed to |
| a use case cannot be completed under the design | stage 4, or 5 |
| an acceptance criterion is not observable | this stage rewrites it, with approval — it owns no section, but a criterion's wording is not a design change |
a criterion or a use case reaches a feature built after it, or the order contradicts a depends | stage 2 — which reading holds is a horizon decision, never a rewording |
| two statements contradict each other | whichever stage wrote the later one |
A shortfall is never patched in place. Writing a missing use case here means writing one that no stage ever walked against a data model.
Run the mechanical pass first
Cheap, precise, and worth clearing before anybody reads prose. Every rule below belongs to ../hora/references/spec-format.md.
1. Every required section present:
the project name, written directly in spec.md
the repository layout, written directly in spec.md
actors and roles / implementation scope / existing assets / terminology /
non-functional requirements / manual verification / implementation plan /
version acceptance criteria (check 10 below)
— each in spec.md's own text or in a declared Source
2. Every feature section:
a <!-- usecases --> block, or one on its feature file's H1
an <!-- acceptance --> block
id, target, depends — and target naming a repository the layout declares
— a section carrying <!-- baseline: inventoried --> owes neither block:
missing-usecase and missing-acceptance are not raised for it, and
nothing else is suspended. Checks 4 and 5 below apply to it in full,
and a use case, an acceptance criterion, a screen section or a
data-model table INSIDE it is itself a finding, blocking: yes
3. Every id unique across the version. No `--` in any file or folder name
4. Every operation states its kind. No input whose fields are unknown
5. Every operation states a caller (stage 6)
6. Every file under specs/<version>/ reachable by a link from spec.md —
except request/ and its contents, and an empty directory's .gitkeep,
which raise nothing (spec-format.md, "a drop-off convention")
7. The version in the document matches the directory name
8. Nothing written into a past version's directory
9. Every row of .hora/spec/<version>/_divergence.md names where it was
routed — a blank Routed to cell goes back to the stage that owns the
row's subject (stages.md, "What sends a run back into a stage")
10. The version's own acceptance criteria are there — the section present,
`none` or every criterion carrying `spans:`, every named id a feature
the document holds, and `rests on:` on every criterion that reaches a
listed one
11. No feature's block reaches forward (below). Walk the implementation
plan's order once, and check each feature's use cases and acceptance
criteria against what is built by then
A listed section carrying any of those four is itself the finding, and it goes back to the stage that wrote the offending block — stage 1 for a use-case or acceptance block, stage 4 for a data-model table, stage 5 for a screen — and to stage 1 whenever the resolution is that the feature should never have been listed, since the annotation is stage 1's to remove. What made the section admissible was that it claims nothing, and a criterion sitting inside it is a pass waiting to be claimed. Where nobody present can say which half was meant, record a contradiction (blocking: yes) rather than pick.
Report the count, not just the findings. "17 sections, 6 features, 3 listed, 0 missing blocks, 4 version criteria" is what says the pass actually ran.
Check 11 needs two sections at once, so it is worth stating how it runs:
1. Take the implementation plan's order, and check it against `depends`
first: every feature after the features it depends on. An edge
pointing forward makes the rest of this check meaningless, because
"what is built by then" is not what the order says
2. Walk the features in that order, carrying the set built so far
3. For each feature, read its two blocks against that set plus the feature
itself. A criterion or a use case naming anything o
阅读完整来源 ↗