跳至正文
OpenAgentSkill
浏览已开放 · 目录记录日期 2026-11-21 · 自动更新和账户服务暂时关闭。
开发与测试

quality-gates

Use when setting up or changing a project's lint, type, test, coverage, build, size, audit, complexity or dead-code checks, when a commit, pull request or merge is being prepared, and when a check fails or someone proposes to disable, skip or loosen one.

NoobyGains · 已有静态检查记录

安装与使用

运行命令前先阅读来源与依赖说明。复制命令不会自动安装或执行。

npx skills add NoobyGains/godmode --skill quality-gates

技能说明


name: quality-gates description: "Use when setting up or changing a project's lint, type, test, coverage, build, size, audit, complexity or dead-code checks, when a commit, pull request or merge is being prepared, and when a check fails or someone proposes to disable, skip or loosen one."

Quality Gates

Anything a machine can check, a machine checks, on every change, in CI, with the same configuration everyone runs locally. A check that only runs when someone remembers is a suggestion. When a check fails, the code changes; the check does not.

The Prime Directive

NEVER DISABLE, SKIP OR LOOSEN A CHECK TO MAKE IT PASS

No exceptions. No workarounds. No shortcuts.

When to Use

Required:

  • Setting up a new project or a new CI pipeline.
  • Before a commit, a pull request or a merge: run the gates locally and read the output.
  • When a gate fails, in CI or locally.
  • When anyone (you, a subagent, a reviewer, the user) proposes to turn off a rule, add a suppression comment, lower a threshold or skip CI.

Skip:

  • Nothing in an existing project. In a throwaway spike, agree with the user which gates apply and say so.

The Protocol

  1. Inventory what exists. Read the project's scripts (package.json, pyproject.toml, Makefile, Cargo.toml, go.mod), the linter and type-checker configs and the CI workflow files. List which of the eight gates below are configured, which run in CI, and what their thresholds are. Use the project's own commands; do not invent new ones when the project already has them.

  2. Run every configured gate locally and record the output. Run the full command, not a subset, and read the exit code and the counts. A gate you did not run this session has no status.

  3. Fix failures in the code. A lint warning is fixed in the code. A type error is fixed in the types. A coverage drop is fixed with tests (written with godmode:test-first). A vulnerable dependency is upgraded, replaced or, if no fix exists, recorded with the user's decision and a review date.

  4. Add missing gates when you set up or are asked to harden a project. Add them in the order of the table below, one per commit, each green before the next. Adding a gate to an existing codebase that fails it: fix the existing violations first, or set the ratchet at today's level and record a plan to tighten it; never land a gate that is red on arrival.

  5. Make CI enforce what runs locally. The same commands, the same configs, required on every pull request, failing the job on any violation. Check that each tool really exits non-zero on a finding before you trust it in CI; run it once against a known violation and read the exit code.

  6. Handle a request to loosen a gate. Stop, and put the question to the user with the evidence: which rule, which code triggers it, why the rule might genuinely be wrong for this project. A rule that is wrong for the project is changed in the config file with a comment that explains why, and the change is a disclosed, reviewed change. A rule that is inconvenient stays.

  7. Report. Hand the gate results to godmode:completion-gate as evidence: each gate, the command, the result.

The Eight Gates

GateStandardFails when
LintZero errors and zero warningsAny warning or error
TypesStrict mode, zero errorsAny type error
Tests and coverageSuite green; coverage never drops (ratchet)A failing test, or coverage below the recorded floor
BuildClean build, zero warningsNon-zero exit or any warning
Size budgetBundle or binary within the agreed budgetOver budget
Dependency auditNo known high or critical vulnerabilityA high or critical advisory without a recorded decision
ComplexityFunctions under the agreed thresholdA function over it
Dead codeNo unused files, exports or dependenciesAn unused item

Lint

Zero warnings, because a warning that is tolerated today is noise that hides tomorrow's real one. Commit the config. Report unused suppression comments too.

  • JavaScript and TypeScript: eslint . --max-warnings 0 --report-unused-disable-directives.
  • Python: ruff check ..

A suppression comment is allowed only with a reason on the same line and, where the project uses them, an issue link. A bare eslint-disable, # noqa or @ts-ignore is a failing gate.

Types

  • TypeScript: "strict": true plus noUncheckedIndexedAccess, noImplicitReturns, noFallthroughCasesInSwitch and noImplicitOverride; run tsc --noEmit in CI.
  • Python: mypy --strict (or pyright in strict mode, if the project already uses it).

any, # type: ignore and casts that hide a real mismatch are type errors you chose not to fix. Each one needs a reason in a comment.

Tests and the coverage ratchet

Coverage is a floor that only moves up. Record today's number in the config; CI fails when a change drops below it; when coverage rises, raise the floor.

  • Jest: coverageThreshold.global with lines, branches, functions, statements.
  • Vitest: coverage.thresholds; `autoUpdat
阅读完整来源 ↗