数据与分析
sql-query-reviewer
Reviews SQL queries for correctness, performance and safety problems such as SELECT star, missing indexes, unbounded updates, implicit casts and injection risks. Use when the user asks to optimize a query, explain why a query is slow, or check SQL before it runs on production data.
Lethe044 · 已有静态检查记录
安装与使用
运行命令前先阅读来源与依赖说明。复制命令不会自动安装或执行。
npx skills add Lethe044/agentskill-kit --skill sql-query-reviewer技能说明
name: sql-query-reviewer description: Reviews SQL queries for correctness, performance and safety problems such as SELECT star, missing indexes, unbounded updates, implicit casts and injection risks. Use when the user asks to optimize a query, explain why a query is slow, or check SQL before it runs on production data. license: MIT metadata: version: 1.0.0 author: Lethe044 tags: [sql, database, performance, review]
SQL query reviewer
When to use
- A query is slow or times out.
- The user is about to run an
UPDATEorDELETEon real data. - SQL is built from user input in application code.
Checklist
Safety first
UPDATEorDELETEwithout aWHEREclause. Ask for confirmation and suggest running aSELECT COUNT(*)with the same condition first.- Wrap destructive statements in a transaction and show how to roll back.
- String concatenation of user input into SQL. Replace it with bound parameters.
Correctness
NULLcomparisons written with=instead ofIS NULL.LEFT JOINfollowed by aWHEREcondition on the right table, which silently turns it into an inner join.GROUP BYthat does not match the selected columns, andCOUNT(column)used whereCOUNT(*)was meant.NOT INwith a subquery that can returnNULL. PreferNOT EXISTS.
Performance
SELECT *on wide tables. List the columns that are used.- Functions on indexed columns in
WHERE(WHERE LOWER(email) = ...). Suggest an expression index or a different predicate. - Leading wildcards (
LIKE '%term') that cannot use an index. - Missing indexes on join and filter columns. Ask for
EXPLAINoutput instead of guessing. OFFSETpagination on large tables. Suggest keyset pagination.ORDER BYwithoutLIMITon large results, andDISTINCTused to hide a bad join.
Steps
- Identify the database engine. Advice differs between PostgreSQL, MySQL, SQLite and SQL Server.
- Go through the checklist and list only real findings, most serious first.
- Show the rewritten query next to each finding.
- If performance is the question and no
EXPLAINoutput was given, ask for it and say what to look for (sequential scans, row estimates far from actual rows).
Example
Input: DELETE FROM sessions WHERE created_at < now() - interval '30 days'
Review: valid, but deletes an unknown number of rows. Run SELECT COUNT(*) with the same condition first, delete
in batches if the count is large, and keep it inside a transaction until the result looks right.
Errors
If the schema is unknown, say which assumptions the review makes about indexes and types.