interface-review
Reviews your work across multiple categories like UI, typography, layout, color, writing and accessibility and gives you a detailed analysis of the findings.
jakubkrehel · 已有 AI 审核记录
安装与使用
运行命令前先阅读来源与依赖说明。复制命令不会自动安装或执行。
npx skills add jakubkrehel/skills --skill interface-review技能说明
name: interface-review disable-model-invocation: true description: Reviews your work across multiple categories like UI, typography, layout, color, writing and accessibility and gives you a detailed analysis of the findings.
Change review
This skill reviews a change rather than a screen. It resolves the scope, expands the changed files to the surfaces they affect, reads both sides of the diff and classifies every finding.
Scope is all it owns. Domain rules belong to the better-* skills. Severity, consolidation, coverage, the cap and the verdict belong to better-interface, which this skill hands the review to.
Correctness, tests, security and performance belong to the project's general code review. Name the concern once and move on.
The change, not the codebase
The author is asking "did I make this worse?". Report what the change caused and stay mostly quiet about what it merely touched. Three pre-existing findings is a courtesy; thirty is a different review and one nobody asked for.
Read the change before forming an opinion of it. The stated intent decides what counts as incomplete, and a skimmed diff produces findings about code the next hunk already fixed.
Core principles
1. Resolve the change scope first
The whole invocation is the target, so /interface-review pr 482 reviews pull request 482. Scope resolution holds the accepted targets and how each resolves.
With no target supplied, resolve in this order and stop at the first match:
HEADis ahead ofgit merge-base origin/<default-branch> HEAD: that range plus any uncommitted changes, with the commit count and the uncommitted file count stated separately.- The working tree is dirty: the uncommitted changes.
- Neither: there is no change to review. Stop and ask, per With no change, ask rather than invent one.
Order matters. Check the working tree first and one stray formatting edit shadows a twelve-commit branch, with the report still claiming full coverage.
Exclude lockfiles, snapshots, generated output, vendored code and binaries, and name what you excluded. An empty scope after exclusions reaches the same place by a different route.
2. With no change, ask rather than invent one
A clean tree with nothing ahead of the merge base means the user asked to review a change that does not exist. Never fall back to HEAD~1..HEAD on your own. The last commit is whatever happened to land, often a merge, often someone else's work, and a report on it is indistinguishable from a report on what the user meant.
State the repository facts you found, then offer the routes and wait. Nothing to review holds the facts to gather:
- The last commit,
HEAD~1..HEAD, named by short SHA and subject, so the user sees what they would get before choosing it. - A target they name:
pr <n>, a branch, a ref, or a range, resolved per Resolve the change scope first. - A whole-repository interface audit, which is not a change review. Hand it to
better-interfaceas a repository-scope review, without this skill's scope block, statuses, or pre-existing section. With no change, every finding is pre-existing and the classification says nothing.
Check for an open pull request on the current branch before asking, and offer it first. A branch whose commits already landed resolves to no change, while its pull request is still exactly what the user meant.
Where the scope emptied out after exclusions, say which files were excluded and ask the same way. Never report a review of nothing as Approve.
3. A diff is not a surface
A changed file is evidence, not the review subject. Its blast radius is the set of surfaces it renders in; review those.
Expand the blast radius one hop by default: the direct importers and callers. Expand a second hop only for design tokens, theme values and shared primitives, where one line reaches the whole product.
Review at most five consumers, ordered by the rule in Scope resolution, then state how many you did not expand. A sweep with no bound cannot support the coverage it claims, and an unstated cutoff reads as completeness.
4. Read the removed lines
Regressions are invisible in the post-change state. Read the - side of every hunk against Removed signals.
A signal is a lead, not a finding. A removal is only a regression when nothing in the change replaces it, and the domain skill owns that judgement. Route each unmatched removal to its owner, report only what that skill confirms and status it Regression. That tells the author they broke something that worked rather than made a new mistake.
5. Classify every finding
Give every finding one status:
Introduced: the change created it.Regression: the change weakened something previously correct.Pre-existing: present in the touched code but not caused by this change.
Status by what the diff touched, not by which file it sits in: a line the change never touched is Pre-existing even three lines from a hunk. Confirm against the base ref when it matters:
git blame -L <line>,<line> "$BASE" -- path/to/file
Hand every finding up with its status attached and let better-interface apply its cap and verdict rules.
6. Hold the change to its stated intent
Read the pull request title and body, the linked issue and the commit messages, then review whether the interface delivers what they claim.
This is what surfaces the incomplete change. A surface review cannot see it, because it inspects the states that are present, and here the point is the ones that are absent:
- A new variant, size, or theme applied to some states but not all: hover, focus, active, disabled, loading, selected.
- A new user-facing string with no entry in the translation catalogue the project maintains.
- A new component with no empty, loading, error, disabled, o