安全
review-review
Use when code changes need review before merge - validates architecture, types, security, and test coverage.
herbert-julio-azion · 已有静态检查记录
安装与使用
运行命令前先阅读来源与依赖说明。复制命令不会自动安装或执行。
npx skills add HerbertJulio/specialist-agent --skill review-review技能说明
name: review-review description: "Use when code changes need review before merge - validates architecture, types, security, and test coverage." user-invocable: true argument-hint: "[scope]" allowed-tools: Read, Bash, Glob, Grep
Perform a full code review of changed files, validating against docs/ARCHITECTURE.md.
Scope: $ARGUMENTS (if empty, review files changed in git)
Steps
- Identify changed files:
git diff --name-only HEAD~1 2>/dev/null || git diff --name-only --cached 2>/dev/null || echo "Please specify the files"
- Run automated checks:
npx tsc --noEmit
ng lint
ng test --watch=false
2b. Run /review-check-architecture $SCOPE for automated pattern validation.
3. Check ARCHITECTURE.md patterns:
- Services: HttpClient only, no try/catch, no transformation, inject(HttpClient)
- Adapters: pure functions
- Stores: signal-based, private WritableSignal, public asReadonly()
- Components: standalone, input()/output() signals, OnPush, < 200 lines
- Naming: kebab-case files, PascalCase classes
- Boundaries: no cross-module imports
- DI: inject() everywhere, no constructor DI
-
Classify:
- VIOLATION - breaks ARCHITECTURE.md
- ATTENTION - recommended improvement
- COMPLIANT - correct
- HIGHLIGHT - positive highlight
-
Produce report with verdict: Approved | With caveats | Requires changes