design-review
Reviews one design document for completeness, internal consistency, implementability, and design standards. Before handing to programmers.
Donchitos · 已有静态检查记录
安装与使用
运行命令前先阅读来源与依赖说明。复制命令不会自动安装或执行。
npx skills add Donchitos/Claude-Code-Game-Studios --skill design-review技能说明
name: design-review description: "Reviews one design document for completeness, internal consistency, implementability, and design standards. Before handing to programmers." argument-hint: "[path-to-design-doc] [--review full|lean|solo]" user-invocable: true allowed-tools: Read, Glob, Grep, Write, Edit, Bash, Agent, AskUserQuestion model: sonnet
!source "${CLAUDE_PROJECT_DIR:-.}/.claude/hooks/yaml-helper.sh" 2>/dev/null && resolve_config --keys review_mode,automation,workflow,system_overrides
Resolved above — use as-is; --review overrides review_mode. No block →
defaults in .claude/docs/config-resolution.md.
Phase 0: Parse Arguments
See .claude/docs/director-gates.md for the full check pattern. Individual gate definitions live in .claude/docs/director-gates/[gate-id].md — the spawned agent reads its own gate file; do not read it in the parent session.
Every AskUserQuestion call follows .claude/docs/automation-modes.md
(collaborative asks always · guided major-only · autonomous logs and proceeds;
automation_always_ask categories always prompt).
workflow for the GDD under review — use the system_overrides row for <system> if the block lists one, else the project value. Validation scope follows the tier:
full— all 8 sections validated; any missing section blocks approval.standard— the 5 required sections (Overview, Detailed Rules, Edge Cases, Dependencies, Acceptance Criteria) block if missing; Formulas blocks only when the system defines numeric rules (rates, curves, thresholds, costs — the category is a hint, not the test); Player Fantasy and Tuning Knobs are advisory (warn, never block) unlessworkflow_overridesrequire them.minimal— no GDD is expected; if one exists, validate the 5 standard sections advisorily.
Resolved mode controls how thorough this review is:
full: Complete review — all phases + specialist agent delegation (Phase 3b)lean: All phases, no specialist agents — faster, single-session analysissolo: Phases 1-4 only, no delegation, no Phase 5 next-step prompt — use when called from within another skill
Phase 1: Load Documents
Freshness check first — a re-review of an unchanged document costs full price (~46k tokens, measured) and reproduces the same verdict. Run:
Bash: bash .claude/scripts/review-receipts.sh check "design/gdd/reviews/[doc-name]-review-log.md" "[target-doc-path]" "design/registry/entities.yaml"
The registry is in the check because this review consults it for
cross-document facts — an unchanged GDD reviewed against a changed
registry can reach different conclusions, so the skip is only safe when
every listed line reads UNCHANGED (an absent registry simply doesn't
appear in the output and doesn't block the skip).
- All
UNCHANGEDand the log's latest entry carries a verdict — surface it: "This document is byte-identical to its last review on [date] (verdict: [verdict])." If that verdict was APPROVED, offer viaAskUserQuestion:[A] Use the prior verdict (Recommended)/[B] Re-review anyway—guidedproceeds with [A] and notes it;autonomouslogs vialog_decisionand uses the prior verdict. If it was NEEDS REVISION or MAJOR REVISION NEEDED, say so plainly: the document has not changed since it failed review — the prior findings stand; revising the document is the next step, not re-reviewing it. Offer to display the prior findings from the log. - Only the registry line reads
CHANGED(docUNCHANGED) — the prior verdict stands except for cross-document facts: re-verify the doc's registry-sourced values against the new registry and re-issue the verdict; escalate to a full re-review only if a conflict appears. - Target doc
CHANGEDorNEW, orRECEIPT: NONE— proceed with the full review below. Do not offer a partial/delta re-review that skips reading or re-analyzing unchanged sections. Measured against a full review: three independent designs (a straightforward section-scoped pass, one with an explicit forced whole-document scan step, and one gated on a genuinely thorough two-round prior review) each caught only 2 of 6 real defects a full review found on the same document, and the most careful version cost more tokens than the full review while catching the same reduced fraction. "Unchanged since last review" only means byte-identical to what was reviewed then — it says nothing about whether that prior pass was itself complete, and no amount of "scan everything anyway" instruction reliably overcame a model's attention naturally narrowing to the flagged change.
Read the target design document in full. Read CLAUDE.md to understand project context and standards.
For cross-document facts, prefer the registry over sibling GDDs. If
design/registry/entities.yaml exists and lists entries for this system,
grep it — these are the established facts this GDD must not contradict, and they
replace reading sibling GDDs to rediscover them:
Grep pattern="source: design/gdd/[system].md" path="design/registry/entities.yaml" output_mode="content" -A 6
Grep pattern="design/gdd/[system].md" path="design/registry/entities.yaml" output_mode="content" -B 8
The first finds entries this system owns — the -A 6 context includes their
referenced_by: block. The second finds entries that reference this system —
referenced_by: is a block sequence (the key and its paths are on separate
lines), so match the path with -B 8 context to see the owning entry, not a
referenced_by.*name one-liner (which never matches the block form).
If design/registry/entities.yaml does not exist, or lists no entry for this
system — the file ships as an empty stub, so this is the default until
/design-system has populated it — fall back to reading the related GDDs the
target doc names in its Dependencies section. Bound the read to those, not to
everythi