跳至正文
OpenAgentSkill
浏览已开放 · 目录记录日期 2026-11-21 · 自动更新和账户服务暂时关闭。
开发与测试

pr-review

Review GitHub pull requests critically and contextually, including first reviews, re-reviews after requested changes, external reviewer or bot feedback, codebase-fit checks, validation, inline comment drafts, and merge decisions. Use when reviewing a PR, checking whether review comments were addressed, evaluating CodeRabbit or another review, preparing review comments, or deciding whether a PR is ready to merge.

dannote · 已有静态检查记录

安装与使用

运行命令前先阅读来源与依赖说明。复制命令不会自动安装或执行。

npx skills add dannote/dot-pi --skill pr-review

技能说明


name: pr-review description: Review GitHub pull requests critically and contextually, including first reviews, re-reviews after requested changes, external reviewer or bot feedback, codebase-fit checks, validation, inline comment drafts, and merge decisions. Use when reviewing a PR, checking whether review comments were addressed, evaluating CodeRabbit or another review, preparing review comments, or deciding whether a PR is ready to merge.

Pull Request Review

Review before mutating. Read the repository's AGENTS.md, CONTRIBUTING.md, PR template, and relevant bot instructions before judging the change. Treat those files as the project's source of truth; do not import conventions from another repository.

Choose the workflow

ContextRoleOutput
First reviewReviewerEvidence-based findings and one recommendation
Re-review after feedbackFollow-up reviewerStatus of each requested change plus regression findings
Merged or closed PRAuditorRetrospective findings and any separate follow-up action
CodeRabbit, Copilot, or contributor reviewMaintainerIndependently verified classifications
CI and checksReviewerAttributed pass, PR failure, infrastructure failure, flake, skip, or unknown
Preparing commentsMaintainer reviewerExact concise inline-comment draft
Approved fix or mergeMaintainer/implementerScoped action and validation result
  • First review: inspect the final diff, history, discussion, checks, and relevant source/tests.
  • Re-review: compare the reviewed commit SHA with the current head before classifying anything. Build the requested-change list from maintainer reviews, inline threads, author responses, and later commits. Mark each item as maintainer-requested, external suggestion, or newly discovered, then classify it as addressed, partial, unresolved, or obsolete from the current diff. If no commits or relevant changes followed the review, say so directly; do not infer fixes from the PR body or commit message.
  • Merged or closed PR: review retrospectively. Do not recommend merging, approving, or requesting changes; identify only lessons or a separate follow-up warranted by current code.
  • External review: verify each CodeRabbit, Copilot, or contributor finding against the current head, current PR body, current conversation, and repository policy; classify it as valid, invalid, stale, duplicate, or low-value. A bot threshold is not a project requirement unless repository guidance or CI makes it one; do not add comments or code solely to satisfy an unsupported metric.
  • CI and checks: inspect failing logs, not only check summaries. Attribute each relevant result as passing, failing because of the PR, infrastructure failure, flaky, cancelled/blocked, skipped/not applicable, or unverified. Report the actual checks; do not inflate the count with service statuses or infer checks that are not present.
  • Draft comments: map valid findings to the smallest useful line range, prefer inline comments, remove duplicates, and show the exact draft.
  • Fix or merge: only act after the user explicitly chooses that action. Use vibe-merge when reimplementing selected ideas instead of merging a PR wholesale.

Do not conflate these workflows. A request to review is not permission to comment, request changes, edit code, push, or merge.

Inspect in this order

  1. Establish the PR state, merged/closed time when applicable, base branch, worktree state, PR number, author, scope, current head SHA, and formal review decision.
  2. Read repository guidance and the PR template. Check whether guidance files differ between the base and PR branch.
  3. Read the PR title, current body, commits, timeline, formal reviews, inline comments, reactions, and issue conversation. Look for maintainer requests, external suggestions, author replies, resolved threads, and changed scope. Do not treat thanks, emoji, or reactions as approval; attribute formal approvals and change requests to their actual authors, and do not mistake a bot approval for maintainer approval.
  4. Inspect the complete diff against the correct base. Read surrounding source, analogous existing implementations, definitions of referenced helpers, and nearby tests. Resolve accessible dependencies instead of leaving findings based on assumptions.
  5. Check CI and external reviews. Inspect statusCheckRollup and failed logs rather than claiming CI is unavailable after a limited query. Separate infrastructure failures from failures caused by the change.
  6. Run focused checks and real-runtime or visual validation when the change requires it. Do not claim validation from a command you did not run.

Use gh for GitHub data. Prefer structured output and line-aware comments, for example:

gh pr view <number> --comments --json title,body,author,baseRefName,headRefName,commits,reviews,comments,statusCheckRollup
gh pr diff <number>
gh api repos/OWNER/REPO/pulls/<number>/comments

Review lenses

Check only lenses relevant to the change, but always check codebase fit:

  • Correctness: behavior, edge cases, regressions, error paths, concurrency, and data loss.
  • Codebase fit: existing abstractions, package ownership, naming, file layout, dependencies, public APIs, and duplicati
阅读完整来源 ↗