code-review
RenoDX pull request code review checklist for HDR/SDR matching, neutral defaults, tonemap/LUT shaders, SDR LUT clipping/domain mistakes, renodx::lut tooling, SwapChainPass, HDR10-preferred SDR/HDR output toggles, rare scRGB paths, resource upgrades, inverse-tonemap rejection, vanilla look preservation, actionable review comments, mod PR scope hygiene, unrelated core files, and sensible commits. Use when performing Copilot code review.
clshortfuse · 已有 AI 审核记录
安装与使用
运行命令前先阅读来源与依赖说明。复制命令不会自动安装或执行。
npx skills add clshortfuse/renodx --skill code-review技能说明
name: code-review description: "RenoDX pull request code review checklist for HDR/SDR matching, neutral defaults, tonemap/LUT shaders, SDR LUT clipping/domain mistakes, renodx::lut tooling, SwapChainPass, HDR10-preferred SDR/HDR output toggles, rare scRGB paths, resource upgrades, inverse-tonemap rejection, vanilla look preservation, actionable review comments, mod PR scope hygiene, unrelated core files, and sensible commits. Use when performing Copilot code review."
RenoDX Code Review Skill
Use this skill when reviewing RenoDX pull requests. Apply it together with root AGENTS.md, the nearest nested AGENTS.md, .agents/skills/swapchain-resource-analysis/SKILL.md, and .agents/skills/handle-sdr-tonemap-lut/SKILL.md when relevant.
Review stance
Copilot review should comment when a PR is technically buildable but violates RenoDX HDR behavior. Do not let a PR pass silently just because it compiles if the mod changes the default look, clips HDR through SDR, or treats the final swapchain frame as an HDR source.
Review comments should be helpful and actionable: name the risky behavior, explain the missing proof or invariant, and suggest a concrete RenoDX pattern to employ. Mentioning another mod can be useful when pointing to a specific file, bridge, or technique, but do not assume every existing mod is high quality or treat a mod name as proof by itself.
Every Copilot code review must include a RenoDX review checklist section in the review body. Do not leave a review without the checklist. Mark each relevant item as Pass, Needs comment, or N/A; leave actionable comments for every Needs comment item.
Required review checklist
- PR scope and commits are tidy: mod PRs are mostly target game/mod changes plus required shared support.
- Review comments are helpful: each issue explains the risky behavior or missing proof and suggests a concrete RenoDX pattern.
- Defaults preserve the original/vanilla look as closely as practical; extra HDR look, contrast, saturation, or brightness is opt-in.
- Preset Off/reset and Vanilla/0 behavior are clear; Vanilla/0 is not treated as full Off if grading/effects remain active.
- The PR does not implement final-frame inverse tonemapping from a completed SDR swapchain/backbuffer.
- Tonemap/LUT shaders prove the
untonemapped,neutral_sdr, andgraded_sdrsignals used byToneMapPassorUpgradeToneMap. ToneMapPass, PsychoV, and other tonemappers receive linear input; encoded/gamma/sRGB values are decoded before tonemapping.- Vanilla LUT paths prove their domain, sampling, masks/strength/scaling, and HDR bridge/reconstruction strategy.
- Hard clips,
saturate, UNORM writes, or lower-format copies do not destroy HDR range before HDR-critical work is complete, except scoped Vanilla/0 resource-clamp emulation. SwapChainPassis only final output encoding for a proven intermediate, not hidden tonemap replacement, LUT reconstruction, or inverse SDR expansion.- Output mode prefers HDR10/PQ with an SDR/HDR toggle; scRGB is used only for rare, justified compatibility or integration cases.
Must-comment issues
Leave a review comment when changed code does any of the following:
- Makes the default output more contrasty, more saturated, brighter, or more stylized than vanilla without an explicit opt-in slider or named preset such as
HDR Look. - Uses HDR headroom as a reason to redesign the image instead of matching the original/vanilla look as closely as practical at default settings.
- Starts from the completed SDR swapchain/backbuffer and applies an inverse curve, peak-nits multiplier, AutoHDR/RTX HDR/ReShade-style expansion, or similar final-frame heuristic.
- Feeds an SDR LUT from a hard-clipped/log-shaped HDR or pre-LUT scene signal (
saturate,min(max(...), 1)) and then uses the sampled LUT result as output orgraded_sdrwithout a matching explicitneutral_sdror reconstruction. Two-argumentToneMapPass(untonemapped, graded_sdr)is not enough proof when the LUT input was a different clipped SDR baseline. - Treats a hard clip or
saturateneutral as a complete LUT bridge when the clip collapses saturated highlights to white or wrong hues. For visible hard-clip-to-LUT behavior, expect Wobbly Life-style max-channel/gamut compression and reconstruction or Silksong-style selective hue/saturation clip emulation. - Leaves a game LUT as an afterthought: a raw sample, skipped LUT, or unchanged sampler path may be valid vanilla preservation, but review should check for missing LUT-domain proof,
renodx::lut::Configsetup, strength/scaling, masks/blends, SDR bridge, or HDR reconstruction. - Assumes a raw LUT sample is enough when the vanilla path uses packed 2D sampling, tetrahedral sampling, masks, strength, scaling, generated LUTs, user LUTs, sRGB/gamma domains, PQ/HDR/log domains, or multiple LUT draws.
- Assumes a vanilla SDR LUT uses linear input without proof. Most vanilla LUTs are sRGB/gamma-domain; encoded values must not be fed directly into
ToneMapPassor any tonemapper. - Uses raw
saturate(untonemapped)or an equivalent hard clip of the HDR source asneutral_sdr, a LUT bridge, or proof that a hard-clip/no-tonemap path is handled. This does not include a Vanilla/0 path deliberately emulating the original RGBA8U/UNORM resource clamp after a resource upgrade. - Feeds encoded/gamma/sRGB color into
ToneMapPass, PsychoV, or another tonemapper instead of decoding to linear first. - Treats
ToneMapPasswithRENODX_TONE_MAP_TYPE == 0/ Vanilla as a full Off preset while user grading, HDR-look controls, or custom effect overrides remain active. - Replaces a real upstream signal with
ToneMapPassor PsychoV without preserving required vanilla presentation effects such as exposure, bloom, fades, vignette, LUT masks, grade strength, or output-domain expectations. - Adds
saturate,min/max, UNORM resolves, or lower-format copies before HDR-critical work is complete, destroying values above SDR wh