跳至正文
OpenAgentSkill
浏览已开放 · 目录记录日期 2026-11-21 · 自动更新和账户服务暂时关闭。
开发与测试

code-review-csk

Code review discipline: severity-ranked, reasoned feedback on whether a change improves the system's overall code health. review-agent-csk applies it. Use when reviewing a change set, and when acting on a review someone else wrote.

byerlikaya · 已有静态检查记录

安装与使用

运行命令前先阅读来源与依赖说明。复制命令不会自动安装或执行。

npx skills add byerlikaya/claude-starter-kit --skill code-review-csk

技能说明


name: code-review-csk description: | Code review discipline: severity-ranked, reasoned feedback on whether a change improves the system's overall code health. review-agent-csk applies it. Use when reviewing a change set, and when acting on a review someone else wrote.

Code Review

Trigger phrases: "code-review", "review the code", "review the PR", "review my changes", "do a review"

Kit adaptation (local, .claude/): applied by review-agent-csk (read-only). No source name appears in the artifact that goes to the repo (§4.2). Comments are severity-ranked; §4 applies.

Sources, by layer — three different questions, three different authorities:

  • Judgement — how to rank what you found: this kit's own. The two-stage verdict and verifier integrity below exist because the code under review is increasingly written by an agent, and a reviewer that accepts its own say-so is not a reviewer. No external standard covers that yet.
  • Governance — that review happens at all, and findings survive it: NIST SP 800-218 (SSDF) PW.7 and the OpenSSF Scorecard Code-Review check. Both are deliberately silent on the rubric: PW.7.2 says to review "based on the organization's secure coding standards", which is what the rest of this file is.
  • Comment vocabulary: Conventional Comments (CC BY 3.0).
  • Rubric heritage: google/eng-practices (CC BY 3.0) — the priority order and the "code health" bar below are adapted from it, so it is attributed as the licence requires.

Core standard (senior principle)

A change is approved once it reaches the point of improving the overall code health of the system — it does not have to be perfect. Avoid two mistakes:

  • Blocking: a perfectionist, subjective fixation that halts progress. If there is no progress, the code never improves.
  • Laxity: small concessions each time erode code health over time. The approval criterion is "is it better", not "is it flawless". If it is an unwanted feature, it can be rejected even when the design is good.

What to review (priority order)

  1. Design: do the pieces fit together; does this change belong here; should it be added now.
  2. Functionality: does it do what is intended; is it right for the user/developer; edge cases, concurrency.
  3. Complexity: is it more complex than necessary; is there over-engineering / design for a future assumption (YAGNI).
  4. Tests: are there correct, meaningful, sufficient tests; real behavior, not tests for tests' sake. Verifier integrity: flag any change that makes a check pass by weakening the check — deleting or loosening an assertion, lowering a threshold, skipping a test, editing the test instead of the code — rather than fixing the behavior. A test or gate that grades itself lax is worse than none; a verifier must stay external and grounded. Subject integrity: the inverse case — the check is untouched, but what it checked is gone. Flag a change that deletes or stubs the code path, so the check passes over behavior that no longer runs; narrows the run to a subset (fewer cases, one platform, a filtered input set) where the property happens to hold; turns an all-of requirement into an any-of one; or relaxes the rule the code is there to enforce — a widened type, a dropped uniqueness or referential constraint, an exception list holding exactly the failing case. Ask not "does it pass now" but "does the system still do what this check was protecting". Retiring a genuinely obsolete check is legitimate: say so in the diff and name what covers it now.
  5. Naming: names that carry intent, neither too long nor cryptic.
  6. Comments: do they explain the "why" rather than the "what"; no dead/unnecessary comments.
  7. Style & consistency: conforms to the project guide; consistent with the existing conventions.
  8. Documentation: if behavior changed, was the relevant document updated.
  9. Every line: look at every human-written line; do not skip code you do not understand as "it's probably correct".

Writing comments

  • Kind and reasoned: what should change + why. In the language of suggestion, not command.
  • Comment on the code, not the person; judge the code, not the individual.
  • Note what is good, too; do not just hunt for flaws.

Label every comment. An agent writes these, and a human or a tool has to sort them without reading each one — so the label is a field, not a tone. Format: <label> [decoration]: <subject>.

LabelUse it forBlocks?
issuea defect: wrong behaviour, a real riskyes, unless marked non-blocking
suggestiona concrete improvement you are proposingno by default
nitpicktrivial preference — always non-blockingnever
questionyou cannot tell whether it is wrong without an answeryes while unanswered
todoa small necessary change, not worth an issueno
praisesomething worth keeping — say sono

Decorations are (blocking) / (non-blocking); use them whenever the default would be ambiguous. Mapping to the severity split this skill reports: blocker = issue (blocking) or an unanswered question (blocking), suggestion = suggestion / todo, nit = nitpick.

Speed & disagreement

  • Turn it around fast: a pending review lowers productivity; look at it at the first opportunity.
  • In a disagreement, technical fact + data speak, not personal preference. If no agreement is reached, take it face-to-face / escalate to a higher authority — not passive blocking.

Two-stage verdict (verify before you report)

Finding a problem and confirmi

阅读完整来源 ↗