go-error-review
Review Go code for error handling correctness, nil safety, and failure-path integrity including ignored errors, missing wrapping, panic misuse, SQL/HTTP resource lifecycle, and transaction patterns. Trigger when code contains error returns, panic calls, sql.Rows, transactions, HTTP client/server code, or nil-sensitive pointer operations. Use for error-handling and correctness-focused review.
johnqtcg · Static checks on file
Installation
Read the source and dependencies before running a command. Copying does not install or execute anything.
npx skills add johnqtcg/awesome-skills --skill go-error-reviewAbout this skill
name: go-error-review description: Review Go code for error handling correctness, nil safety, and failure-path integrity including ignored errors, missing wrapping, panic misuse, SQL/HTTP resource lifecycle, and transaction patterns. Trigger when code contains error returns, panic calls, sql.Rows, transactions, HTTP client/server code, or nil-sensitive pointer operations. Use for error-handling and correctness-focused review. allowed-tools: Read, Grep, Glob, Bash(go build*), Bash(go vet*), Bash(staticcheck*), Bash(go test*)
Go Error Review
Purpose
Audit Go code for error handling correctness, nil safety, and failure-path integrity. Core question for every function call: "What happens when it fails?"
This skill merges error handling + API request/response correctness + database operation correctness because they share one review lens: "does this code handle failure correctly?"
This skill does NOT cover: security vulnerabilities, concurrency safety, performance, code style, test quality, or business logic — those belong to sibling vertical skills.
When To Use
- Code contains error return values
- Code uses
panic/recover - Code involves
sql.Rows, transactions, connection pools - Code involves HTTP request/response body handling
- Code operates on
[]*Tpointer slices
When NOT To Use
- Security vulnerabilities →
go-security-review - Concurrency safety →
go-concurrency-review - Performance optimization →
go-performance-review - Code style →
go-quality-review - Business logic →
go-logic-review
Mandatory Gates
1) Execution Integrity Gate
Never claim tests ran unless they actually did. If not run: state reason + exact command.
2) Go Version Gate
Read go.mod. Key features:
errors.Is/errors.As(Go 1.13+)errors.Join(Go 1.20+)fmt.Errorfwith multiple%w(Go 1.20+)
3) Anti-Example Suppression Gate
MUST quote specific code evidence. Category match alone insufficient.
Embedded anti-examples:
- "Missing error handling on json.Marshal" — when marshaling known-safe struct with only primitive fields (string, int, bool, no interface fields).
json.Marshalon such structs always returns nil error. - "Missing error wrapping" — when caller already wraps; adding another layer creates redundant context like
"create user: insert user: insert row: ...". Cite the caller's wrapping code. - "Speculative nil dereference" — when caller is internal and always passes non-nil. Cite the caller code proving it never passes nil.
- "Should use errors.Is instead of ==" — direct
==against sentinel from the same package is acceptable. Cross-package comparison must useerrors.Is. - "defer f.Close() ignoring error" — acceptable for read-only file opens. Flag only for write operations where Close flushes buffered data.
4) Generated Code Exclusion Gate
Exclude: *.pb.go, *_gen.go, mock_*.go. Note excluded files in Execution Status.
Workflow
- Define scope — files/diff under review. Apply Generated Code Exclusion Gate.
- Gather evidence — read changed files, identify error-handling patterns:
if err != nil,_ =,panic(,sql.Rows,tx.,resp.Body,[]*T. - Load references — always load
go-error-and-quality.md(error sections); loadgo-api-http-checklist.mdwhen net/http code present; loadgo-database-patterns.mdwhen database code present. - Evaluate ALL 12 checklist items — for each function call, ask "what happens on failure?"
- Apply suppression → format output.
Grep-Gated Execution Protocol
This skill uses mechanical grep pre-scanning to guarantee zero missed checklist items. The model's attention is reserved for semantic judgment on grep hits and semantic-only items.
Execution Order
- Identify target files (from dispatch prompt, or write raw snippet to
$TMPDIR/review_snippet.go) - Run grep for ALL 12 checklist items against target files
- HIT → run semantic analysis to confirm or reject (true positive vs false positive)
- MISS → auto-mark NOT FOUND, skip semantic analysis for that item
- For compound patterns (item 12): run both grep patterns, apply AND logic
- Report only FOUND items (grep-confirmed + semantic-confirmed)
Grep Audit Line
Include in Execution Status: Grep pre-scan: X/12 items hit, Z confirmed as findings
Compound Pattern Protocol
Some items require two grep patterns. Run both:
- Item 12 (Log-and-return): TRIGGER when
log\.\|slog\.HIT ANDreturn.*errHIT in same file
Error Checklist (12 Items)
Error Handling (High)
| # | Item | Code Pattern Triggers | Grep Pattern |
|---|---|---|---|
| 1 | Ignored error | _ = or _ := on error-returning calls. Acceptable only for hash.Write, known-safe fmt.Fprintf to buffer | _\s*[:=]= |
| 2 | Missing error wrapping | return err without fmt.Errorf("context: %w", err) at abstraction boundary | return\s+(nil,\s*)?err\b |
| 3 | Panic misuse | panic() for recoverable errors. Acceptable only in init() or unrecoverable invariant violation | panic\( |
| 4 | Missing errors.Is/As | Direct == on error for cross-package sentinel; type switch instead of errors.As | err\s*[!=]=\s*|[!=]=\s*err |
| 5 | Pointer slice nil guard | []*T elements accessed without nil check before field/method access | \[\]\*\w |
API/HTTP Correctness (High)
| # | Item | Code Pattern Triggers | Grep Pattern |
|---|---|---|---|
| 6 | Unbounded server body | Missing http.MaxBytesReader / io.LimitReader on body decode. Do NOT require r.Body.Close() — framework handles it | r\.Body|Request\.Body|ReadAll |
| 7 | Client response body leak | resp.Body not closed on ALL paths including error path — prevents connection reuse | resp\.Body|Response\.Body |
| 8 | HTTP status code mismatch | 200 for creation (should be 201), 500 for not-found (s |