review
Use to run an independent, clean-context code review of an implemented feature against its spec and acceptance criteria before shipping. Triggers on "review {slug}", "code review the changes for {slug}", "review the diff for {slug}", "is {slug} ready to ship", "/sdd:review {slug}", "переглянь зміни {slug}", "код-рев'ю фічі {slug}", "рев'ю diff". Dispatches the reviewer subagent over the whole feature diff (stage 1 spec/AC compliance, stage 2 quality), collects cited findings, and resolves each with you. Hard-refuses if the feature isn't implemented yet.
genkovich · AI review on file
Installation
Read the source and dependencies before running a command. Copying does not install or execute anything.
npx skills add genkovich/sdd --skill reviewAbout this skill
name: review model: inherit effort: high agents: [reviewer] description: > Use to run an independent, clean-context code review of an implemented feature against its spec and acceptance criteria before shipping. Triggers on "review {slug}", "code review the changes for {slug}", "review the diff for {slug}", "is {slug} ready to ship", "/sdd:review {slug}", "переглянь зміни {slug}", "код-рев'ю фічі {slug}", "рев'ю diff". Dispatches the reviewer subagent over the whole feature diff (stage 1 spec/AC compliance, stage 2 quality), collects cited findings, and resolves each with you. Hard-refuses if the feature isn't implemented yet.
Skill: review
The independent review gate. After implement has written + tested + committed the code, review looks at the whole change at once, with fresh eyes — does it actually satisfy every acceptance criterion, and is it good code? This is distinct from the per-task gate inside implement (which proves each task green): review is the cross-cutting, clean-context pass a human reviewer would do on the PR.
It reuses the shared clean-context discipline (../_shared/critic.md) and the reviewer subagent (read-only). Question phrasing per ../_shared/ask-style.md.
Review-record prose follows artifact_language (carry the language in the reviewer's dispatch prompt) — the verdict literals PASS / CHANGES REQUESTED / REVIEW_CLEAN and cited identifiers stay English → ../_shared/artifact-language.md.
Owner
Tech Lead / a reviewer who did not write the code (independence is the point).
Inputs
<slug>— feature slug.- Gate (hard refuse): an implemented change must exist (commits on the feature branch, or a non-empty working diff). Nothing to review → «run
implement <slug>first». - Read for the review baseline — the whole AC chain, so the trace can be checked end-to-end:
docs/features/<slug>/spec.md§5 (the full AC set — the source of truth, not the diff's trailers),sad.md§6 (the sequence flows/branches each AC should appear in),data-model.md/contracts/openapi.yaml/ Acceptedadr/(the contracts the code must honour),test-plan.md(the AC→test map, if a separate file), andtasks.json(which AC each task claimed).
Protocol
- Scope the diff. Determine the change under review:
git diff <base>..HEADon the feature branch (base = the branch point), or the named changed files. Note theSDD-ACtrailers — the ACs the implementation claims to satisfy. - Dispatch the independent reviewer. Run the
revieweragent —subagent_type: "sdd:reviewer"(read-only, clean context — it re-reads spec/contracts itself, no paraphrase; model perjudgment_model; effortxhighon L/XL viaCLAUDE_CODE_EFFORT_LEVEL, per../_shared/agent-roster.md) — over the diff along the dimensions in./references/review-dimensions.md: stage 1 — every claimed AC genuinely satisfied and the whole §4 user-story set + §5 AC set traced end-to-end (spec → sequences §6 → data-model → api → tasks → implement): every §4 user story has ≥1 AC and a §6 flow, and every §5 AC reaches code+test — spanning every surface declared insad.mdtarget_surfaces(a UI AC traces to a component / e2e-through-UI test, not only a backend one) — flagging any user story or AC that dropped out anywhere in the chain, not only the ACs the diff claims via itsSDD-ACtrailers; stage 2 — conventions, error/edge handling, security, boundary violations, test adequacy. For a large diff, fan out one reviewer per dimension and merge. - Collect cited findings. Each finding cites
file:line+ the AC/contract it touches. Drop uncited findings (per the critic discipline). A clean review returnsREVIEW_CLEAN. If the reviewer ran asynchronously and came back as an idle/completion signal with no report, pull the full report through the host's messaging channel — never accept a verdict without its text (→../_shared/agent-roster.md, shared-contract point 2). - Resolve each finding with the user via
AskUserQuestion: Fix now (hand the actionable finding back toimplement/the author as a follow-up task — re-enter the TDD loop for it) / Defer (record in spec §8 Open questions with owner + due) / Not an issue (the reviewer misread; record why). Never ship an unresolved stage-1 (AC) finding. - Write the review record.
docs/features/<slug>/_review/review-<date>.md: scope (diff stat), findings with verdicts, and the gate result (PASS/CHANGES REQUESTED). - Verdict + next. Then emit the stage-handoff block per
../_shared/handoff.md— What I did + Review (_review/review-<date>.md) + Run next:PASS→ (/clear, then/sdd:ship <slug>);CHANGES REQUESTED→/sdd:implement <slug>for the fixes (no/clear— stay in context to iterate), then re-review the changed surface.
Definition of Done
- The independent reviewer ran over the whole feature diff (not just per-task).
- Every claimed AC was checked for genuine satisfaction; the whole §4 user-story set + §5 AC set was traced end-to-end (spec → sequences → data-model → api → tasks → implement) — every §4 US has ≥1 AC and a §6 flow, every §5 AC reaches code+test — and anything that dropped out anywhere in the chain was flagged, not just the ACs the diff claims. Every in-scope user story / AC is covered or explicitly deferred with owner + due.
- Every finding is resolved (fixed / deferred / dismissed-with-reason); no open stage-1 finding remains.
- A review record exists with a
PASS/CHANGES REQUESTEDverdict. - The clean-context reviewer pass (the whole skill is a verifier) is this skill's structural self-check ([`../_shared/self-