powershell-review
Review PowerShell code against this repository's PowerShell standards and report findings by rule ID. Use when asked to review, validate, analyze, or check PowerShell code for quality or standards compliance.
fadwen · Static checks on file
Installation
Read the source and dependencies before running a command. Copying does not install or execute anything.
npx skills add fadwen/ai-powershell-standards --skill powershell-reviewAbout this skill
name: powershell-review description: Review PowerShell code against this repository's PowerShell standards and report findings by rule ID. Use when asked to review, validate, analyze, or check PowerShell code for quality or standards compliance.
Review PowerShell code against the standards
Read the core rules (.github/copilot-instructions.md, or AGENTS.md if the repository has no such
file) and the topic files they list for the kind of file under review, unless they are already
loaded. Every rule has an ID such as ERR-10; cite it.
Steps
- Establish the target version from
#requireslines and the module manifest. Judge the code against that version, not against the newest one. - Run the tools first when you can: PSScriptAnalyzer, with
-Settings ./PSScriptAnalyzerSettings.psd1when that file exists, and the existing tests. Include what they report. - Read the code for what tools cannot see, in this order:
- Correctness: logic errors, unhandled failure paths, wrong assumptions about a command's output.
- Error handling: the ERR rules, in particular
throwin advanced functions, a missing-ErrorAction Stopinsidetry, and empty or silentcatchblocks. - Security: the SEC rules.
- Functions and output: the FUN rules.
- Version fit: the VER rules.
- Help and style: the DOC and STY rules.
- Confirm each finding before reporting it. Read the surrounding code, and where behaviour is in doubt, run a small test. Do not report a rule violation in code that the change did not touch, unless it is a defect.
- A comment of the form
# Exception to ERR-11: reasonrecords a decision of the project (DOC-22). Do not report the code under it as a finding of that rule. Do report the comment when its reason is missing or no longer matches the code. A comment that names a security rule (SEC) excuses nothing: report the finding, and the comment. Do not propose such a comment as the fix for a finding.
Report
List findings with the most serious first. For each one give the file and line, the rule ID or the word "defect", what is wrong, and the corrected code. Separate requirements (MUST) from recommendations (SHOULD). List the recorded exceptions with their reasons, apart from the findings. State what you ran and what you did not check. If nothing is wrong, say so; do not invent findings.