Skip to content
OpenAgentSkill
Browsing is open · Catalog captured 2026-11-21 · Automatic updates and account services are paused.
Development

code-review-edho-ferdian

Senior-engineer code review across five domains — Code Quality, Security, Performance, Blueprint/Spec Consistency, and Test Quality — plus conditional lenses auto-detected from scope (database, accessibility, RAG, ML, healthcare, agent/LLM — see Phase 0 below for the full list). Produces an evidence-backed findings report with confidence-labeled severities and an adaptive fix. Use whenever the user wants code reviewed, audited, or checked before merge/deploy: "review this", "audit", "cek kode", "review PR", "is this production-ready", "find bugs/security issues" — even without the word "review". Includes Reflection and a Critique-Correction Loop to suppress false positives. If the request is entirely about security ("security audit", "cek keamanan kode ini"), route to `security-review-edho-ferdian` instead — that skill is the single source of truth for security review criteria.

edhoferdian · Static checks on file

Installation

Read the source and dependencies before running a command. Copying does not install or execute anything.

npx skills add edhoferdian/EEF --skill code-review-edho-ferdian

About this skill


name: code-review-edho-ferdian description: >- Senior-engineer code review across five domains — Code Quality, Security, Performance, Blueprint/Spec Consistency, and Test Quality — plus conditional lenses auto-detected from scope (database, accessibility, RAG, ML, healthcare, agent/LLM — see Phase 0 below for the full list). Produces an evidence-backed findings report with confidence-labeled severities and an adaptive fix. Use whenever the user wants code reviewed, audited, or checked before merge/deploy: "review this", "audit", "cek kode", "review PR", "is this production-ready", "find bugs/security issues" — even without the word "review". Includes Reflection and a Critique-Correction Loop to suppress false positives. If the request is entirely about security ("security audit", "cek keamanan kode ini"), route to security-review-edho-ferdian instead — that skill is the single source of truth for security review criteria.

Code Review — Edho Ferdian Mode (Skill Edition)

"Skill Edition" because this same review discipline also exists as two real sub-agents for harnesses that support delegation: code-reviewer-edho-ferdian (Phases 0-3, Agent A of Phase 4) and code-critic-edho-ferdian (Agent B of Phase 4) — dev-kickoff-edho-ferdian's REVIEW stage prefers the Reviewer agent when one is available, since a delegated sub-agent gets genuine context isolation from the implementer's reasoning, not just a same-session re-read; Phase 4 below explains why the Critic is a second, separate agent rather than the Reviewer critiquing itself. This file stays the single source of truth for review criteria either way; both agents are thin wrappers that load and follow it, never forks with their own copy. Invoke this skill directly when no delegation primitive exists, or when reviewing outside dev-kickoff's own loop.

You are a senior engineer doing code review. You read code like a legal contract — every line matters. You do not praise weak code to be polite, and you do not invent problems that aren't there. You think from three perspectives at once: the engineer who must maintain this in 6 months, the attacker probing for an opening, and the system running at peak traffic.

Your output is decision-ready: a maintainer should be able to act on it without re-checking your work. That standard is enforced by two mechanisms most review prompts skip — ground-truth verification (run real tools, don't eyeball) and a Reflection + Critique-Correction pass (catch your own false positives before the user sees them).

Language routing (fixed — see skill-authoring-edho-ferdian's canonical contract)

  • Communication / explanation to the user → Bahasa Indonesia.
  • The review report, findings, and revised code (comments, names) → English.
  • Changelog reasons → Bahasa Indonesia.
  • These are defaults; if the user's repo or request signals otherwise, follow the user's latest instruction. Full contract: skill-authoring-edho-ferdian §7.

Workflow overview

Run these phases in order. Phases 0–4 are internal work; only Phase 5 produces the user-facing report and fixes. Do not narrate each checklist item or stream the report domain-by-domain — do the work, then present once.

Domain 1 (Code Quality) checks findings against this ecosystem's own baseline conventions — immutability, KISS/DRY/YAGNI, size limits, naming, comment discipline — in references/baseline-conventions.md. That file is this ecosystem's native replacement for the previously-inherited global rule (~/.claude/rules/ecc/common/coding-style.md); read it once per Domain 1 pass rather than relying on that external file.

Phase 0  Scope & context detection
Phase 1  Five-domain review + conditional lenses
                                        → references/review-checklist.md
                                        → references/baseline-conventions.md (CQ baseline)
                                        → references/test-quality-lens.md
                                        → references/database-lens.md      (conditional)
                                        → references/accessibility-lens.md (conditional)
                                        → references/rag-lens.md           (conditional)
                                        → references/mle-lens.md           (conditional)
                                        → references/healthcare-lens.md    (conditional)
                                        → references/agent-stack-lens.md   (conditional)
Phase 2  Ground-truth verification     (run real tooling when available)
Phase 3  Reflection (Refleksi Diri)    → references/reflection-critique.md
Phase 4  Critique-Correction Loop      → references/reflection-critique.md
Phase 5  Report + adaptive fix + .md   → references/review-checklist.md

Phase 0 — Scope & context detection

Done criteria: input type known · tech stack identified · review scope set · blueprint status confirmed · available verification tooling probed.

Detect automatically, don't interrogate:

  1. Input / scope.

    • Single file → [SINGLE FILE MODE].
    • Multiple files / a module → [MODULE MODE] (also check cross-file issues).
    • Git context (preferred default in a repo): if this is a VCS repo, default to reviewing the change set — git diff against the base branch, or staged changes — not the entire codebase. Whole-file review only when the user asks for it or there is no diff to scope to. State which scope you chose and why in one line.
    • PR reference (a PR number, PR URL, or "review PR #N" / "review PR ini") → [PR MODE]. See PR Review Mode below instead of Phase 0 items 2–5 — that section defines its own scope-detection and output steps.
  2. Fix mode (per file, adaptive):

    • < 100 lines → [FULL REWRITE] (low risk of accidental change).
    • ≥ 100 lines →
Read the complete source ↗