implement
Disciplined implementation in pi-agent-dashboard: the rebuild matrix (extension→reload, server→restart, client→build+restart, openspec-apply→full rebuild) plus the project''s code discipline rules. Use when writing code, after editing extension/server/client, after applying an OpenSpec change, when unsure what to rebuild, or before committing. Triggers: "rebuild and restart", "TDD this".
BlackBeltTechnology · AI review on file
Installation
Read the source and dependencies before running a command. Copying does not install or execute anything.
npx skills add BlackBeltTechnology/pi-agent-dashboard --skill implementAbout this skill
name: implement description: 'Disciplined implementation in pi-agent-dashboard: the rebuild matrix (extension→reload, server→restart, client→build+restart, openspec-apply→full rebuild) plus the project''s code discipline rules. Use when writing code, after editing extension/server/client, after applying an OpenSpec change, when unsure what to rebuild, or before committing. Triggers: "rebuild and restart", "TDD this".'
Implement
Two halves: how to write the change (discipline) and how to land it in the running system (rebuild + restart).
The skill exists because both halves are easy to get wrong:
- Agents over-engineer simple changes when they're not anchored.
- Agents rebuild the wrong component (or worse, all components when they didn't need to) after editing files.
Quick decision tree
Did you edit code?
│
┌────────┴────────┐
│ │
▼ ▼
src/extension/ src/server/ or src/shared/
│ │
▼ ▼
npm run reload curl -X POST localhost:8000/api/restart
(no build step — jiti runs TS directly)
src/client/ (dev mode) → nothing, Vite HMR
src/client/ (prod mode) → npm run build && restart
Multi-component / openspec → npx tsx .pi/skills/implement/scripts/full-rebuild.ts
Quick check current mode:
npx tsx .pi/skills/implement/scripts/check-mode.ts # prints "dev" or "production"
Restart server (preserves mode unless overridden):
npx tsx .pi/skills/implement/scripts/restart-server.ts # graceful restart, keeps mode
npx tsx .pi/skills/implement/scripts/restart-server.ts --dev # force dev mode
npx tsx .pi/skills/implement/scripts/restart-server.ts --prod # force production mode
Full rebuild (after openspec-apply or multi-component change):
npx tsx .pi/skills/implement/scripts/full-rebuild.ts
full-rebuild.tsdeploys the checked-out dev version to the local running instance (build + restart + reload). It is NOT a feature-implementation step — worktree / Docker-isolated feature work does not run it. The code-review gate is separate (below).Scripts are TypeScript (cross-platform). All invocations use
npx tsxso they work identically on Linux, macOS, and Windows.tsxis already a project dep.
Full matrix with edge cases (dev-mode fallback, fault-tolerant restart, single-restart-path rule) lives in references/rebuild-matrix.md.
Review — two tiers (inner loop vs ship gate)
Review is split by moment. The inner loop runs on an unlimited engine every non-trivial change; the rate-limited cloud gate is reserved for the PR.
Inner loop (during dev, before commit) — review-code discipline. After writing a non-trivial change, review the diff with the review-code skill (eng-disciplines): engine-agnostic — inspect design→correctness→complexity→tests→naming→security, emit labelled findings, fix issue(blocking) surgically, re-review until no blocking finding remains, then commit. Runs on a model engine — no cloud quota spent, so run it freely per change.
Ship gate (opt-in, PR-time) — CodeRabbit. Reserved for the pull request so its quota is unspent during dev. Worktree-safe and server-independent — no build, no restart:
RUN_CR_REVIEW=1 npx tsx .pi/skills/implement/scripts/review-changes.ts # opt in (uncommitted)
npx tsx .pi/skills/implement/scripts/review-changes.ts --ship -t committed --base main
npx tsx .pi/skills/implement/scripts/review-changes.ts # default: skips → use review-code
Warn-and-continue, never blocks: CodeRabbit is cloud rate-limited; on limit / missing CLI / auth failure it prints "deferred to a later cycle" and exits 0. Fix Critical/Warning findings, then commit. See the code-review skill for the CodeRabbit severity triage + fix loop.
openspec-apply: the
review-codeinner-loop pass runs after each task's code is written; the CodeRabbit gate is opt-in at ship (ship-change owns the PR-time review). Both run in the worktree without touching the main server.
Subagent checkpoints (apply loop) — offload read/write-light work, keep the builder inline
The builder (this loop) owns all decisions and code writes — coherence stays in one context. Spawn a subagent (explicit Agent call) only at these signals, to keep the main context sharp:
| Signal in the task / diff | Spawn | Why isolated |
|---|---|---|
| touches auth, secrets, PII, untrusted input, webhooks, or a latency/throughput budget | Audit | deep read-only risk pass → findings; fix inline |
| contextFiles list is large (many files / big) | Explore | distill the spec; else read directly for coherence |
a change landed and docs/ prose needs updating | DocScribe | Rule-6 docs-delegation; caveman-style writes |
Review stays a skill (review-code), not a subagent — review+fix is coherence-critical and wants full context. Tests: run+capture inline (tee→grep); root-cause via systematic-debugging inline. Full rationale: docs/skills-as-subagents.md.
The discipline — write less code, write the right code
The full code-discipline reference lives in references/code-discipline.md. It expands AGENTS.md "Code Instructions" with concrete patterns, anti-patterns, and examples. Headline rules:
| Rule | One-liner |
|---|---|
| 0. kb-first, even as an executor | Before you grep/rg for a symbol, Read a file to learn its purpose, or chase an import, run kb_search / kb agents <path> / kb_neighbors FIRST. Fires on the ACTION, not the intent — knowing which file the task names does not exempt you. |
| 1. Think before coding | State assumptions. Ask via ask_user when unclear. Never speculate about unread files. Confirm major plans. |
| 2. Simplicity first | Minimum code that solves the problem. No speculat |