code-reviewer
Use when asked to review, check or diagnose Spring Boot code: a pull request, diff, module or file before it merges; a slow endpoint or query (N+1, unbounded reads, JPA and Hibernate performance); security, JSpecify null-safety, architecture boundaries or Boot 4 migration risks in existing code; or whether the tests would catch real bugs, proving each finding by running it. Not for Kotlin-only code, non-Spring frameworks, or generic review advice without code context.
a-pavithraa · Static checks on file
Installation
Read the source and dependencies before running a command. Copying does not install or execute anything.
npx skills add a-pavithraa/springboot-skills-marketplace --skill code-reviewerAbout this skill
name: code-reviewer description: "Use when asked to review, check or diagnose Spring Boot code: a pull request, diff, module or file before it merges; a slow endpoint or query (N+1, unbounded reads, JPA and Hibernate performance); security, JSpecify null-safety, architecture boundaries or Boot 4 migration risks in existing code; or whether the tests would catch real bugs, proving each finding by running it. Not for Kotlin-only code, non-Spring frameworks, or generic review advice without code context."
Spring Boot 4 Reviewer (Java 17+)
Rules
- If the repository has a
REVIEW.mdat its root, read it first. Check the change against each rule it lists, and follow what it says to report and skip. - Review only code you have. If no files, diff, or module were given, ask for them.
- Cite a file path and line for every finding. Mark findings in code the change didn't touch as pre-existing.
- Read the Java version from
pom.xmlorbuild.gradle. Boot 4 supports Java 17 and later, so Java 17 and 21 are not findings. Java 26 and 27 targets:../creating-springboot-projects/references/java-version-policy.md. - Recommend virtual threads, reactive code, or a new architecture only with evidence from the code: blocking I/O on request threads, a saturated pool, or a boundary that already leaks.
- Use JSpecify as the null-safety baseline for new Boot 4 code. If the codebase is part way through moving to it, report the plan, not every legacy annotation.
Before Step 1: say who wrote the code
If you wrote or changed the code under review in this session, tell the user that a review from a fresh context is less biased and offer to run it in a general-purpose subagent, giving it the commits and uncommitted changes to review and telling it to follow this skill (code-reviewer). Continue only if they decline. Otherwise, review inline.
Step 1: Load only the references the review needs
| Focus | Read |
|---|---|
| Spring Boot 4 migration patterns and framework changes | references/spring-boot-4-patterns.md |
| Java 25 language and concurrency adoption | references/java-25-features.md |
| Security | references/security-checklist.md |
| Performance | references/performance-patterns.md |
| JPA and Hibernate 7 | references/jpa-performance.md |
| Architecture boundaries and packaging | references/architecture-patterns.md |
| Domain model shape | references/domain-modeling.md, references/value-objects-patterns.md |
| Null safety | references/jspecify-null-safety.md |
| Tests: what they can catch, what they let through | references/test-review.md |
For a phased upgrade plan rather than a review, use the springboot-migration skill.
Step 2: Run the passes that match the request
For a full review, run them in this order.
Pass A: Build and configuration
- Run
../springboot-migration/scripts/scan_migration_issues.py <project>and cite its CRITICAL lines: old starter names, moved imports, old test annotations, Testcontainers 1.x classes. If the script is not there (this skill was copied withoutspringboot-migration), say so in the review and check those four by reading the pom and imports. - Check for version drift: dependencies pinned by hand that the Boot BOM already manages.
Pass B: Architecture
- Name the architecture style in use, then report packages and calls that break it.
- Run the architecture tests if they exist (Taikai, ArchUnit, or Spring Modulith's
ApplicationModules.verify()) and cite their failures. If none exist, recommend thespring-boot-team-harnessskill, whoseCodeRulesTestsholds these rules. A review catches a boundary leak once. A failing build catches it every time.
Pass C: Security, data access, and performance
Read the matching reference from Step 1 and report against it. Report the affected entry points and how a caller reaches the flaw, not only the rule it breaks.
Pass D: Null safety
Check public APIs and method overrides against references/jspecify-null-safety.md.
Pass E: Tests
Follow references/test-review.md:
- Run the suite first, so you know what is red before you change anything.
- Map each class's contract to the test that guards it.
- Check each test against the "runs the real thing" table.
- Prove each finding by running it. Restore every file you break with
git checkout -- <file>. - Report in the test-review format, with the bugs the suite would let through first.
Pass F: Comments
For each comment the change adds or edits, keep it only if it states a constraint the code can't show (an external system's behaviour, a limit, an ordering), why the obvious alternative is wrong, or, on a record or DTO field, what its name can't say: when it is null or empty, or a meaning that depends on state. Use the project's comment rule in AGENTS.md if it has one.
- Delete: comments that restate the name or the code,
@paramor@returnthat repeat the name, notes on what changed, ticket or plan references, and a rule already stated where it is enforced. - Shorten: the rest, to one or two sentences written as one thought. A design decision longer than that belongs in the project's docs, with a one-line pointer in the code.
Report them as one Low finding listing each comment with "delete" or "shorten to: ...". When asked to fix the findings, change only comments, never code.
Boot 4 findings the model often misses
TestRestTemplatewhereRestTestClientis available.- Hand-built
HttpServiceProxyFactorycode where@ImportHttpServicesdoes the same. - Custom API versioning where
spring.mvc.apiversion.*does the same. - Jackson 2 imports or types in a Boot 4 codebase.
@ConcurrencyLimitor@Retryablethat never applies: no@EnableResilientMethods; a class that implements an interface withoutproxyTargetClass = true; or a call from inside the same class, which skips the proxy.- No
package-info.javawhere the project uses JSpecify. - `org.springframe